From: Simon Hausmann <hausmann@kde.org>
Date: Wed, 31 Jan 2007 21:38:07 +0000 (+0100)
Subject: avoid fstat for every file
X-Git-Url: http://crossforests.com/gitweb?a=commitdiff_plain;h=555a9dd9d930b2d53122310b7ce910bd4cf76a21;p=python%2Ffast-export.git

avoid fstat for every file
---

diff --git a/p4-fast-export.py b/p4-fast-export.py
index 45d5157..133447c 100644
--- a/p4-fast-export.py
+++ b/p4-fast-export.py
@@ -57,9 +57,6 @@ def p4Cmd(cmd):
         result.update(entry)
     return result;
 
-def p4FileSize(path):
-    return int(p4Cmd("fstat -Ol \"%s\"" % path)["fileSize"])
-
 def getUserMap():
     users = {}
 
@@ -121,14 +118,15 @@ for change in changes:
         if action == "delete":
             gitStream.write("D %s\n" % relPath)
         else:
-            fileSize = p4FileSize(depotPath)
             mode = 644
             if description["type%s" % fnum].startswith("x"):
                 mode = 755
 
+            data = os.popen("p4 print -q \"%s\"" % depotPath, "rb").read()
+
             gitStream.write("M %s inline %s\n" % (mode, relPath))
-            gitStream.write("data %s\n" % fileSize)
-            gitStream.write(os.popen("p4 print -q \"%s\"" % depotPath).read())
+            gitStream.write("data %s\n" % len(data))
+            gitStream.write(data)
             gitStream.write("\n")
 
         fnum = fnum + 1